Skip to content

feat: display list names instead of generic labels while editing robots #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2025
Merged

feat: display list names instead of generic labels while editing robots #858

merged 1 commit into from
Nov 3, 2025
+30 −21

Conversation

@amhsirak
Copy link
Member

@amhsirak amhsirak commented Nov 1, 2025 •
edited by coderabbitai bot
Loading

fixes #852

Summary by CodeRabbit

  • New Features
    • Improved labeling of scrape list limit fields, which now intelligently derive names from associated workflow actions for clearer identification.

@coderabbitai
Copy link

coderabbitai bot commented Nov 1, 2025 •
edited
Loading

Walkthrough

The renderScrapeListLimitFields function in RobotEditPage.tsx now dynamically derives limit field labels from corresponding scrapeList action names. It retrieves the related action from the robot workflow and uses the action's name, first argument's __name, or defaults to "List Limit {index+1}".

Changes

Cohort / File(s) Summary
Label Derivation in Limit Fields
src/components/robot/pages/RobotEditPage.tsx		 Modified renderScrapeListLimitFields to derive limit field labels from corresponding scrapeList action names instead of generic placeholders, with fallback to indexed defaults. onChange behavior preserved.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Single-file, localized logic change for label derivation
  • Preserved existing onChange behavior and control flow
  • Consider verifying the fallback precedence (action name → first arg's __name → default) matches intended behavior
  • Test edge cases where related action is missing or naming attributes are undefined

Poem

🐰 A rabbit hops through fields so fine,
Where scrape lists now by name align,
No more "List One," no generic call—
Each label knows its action's name so tall!
*~ A very happy refactoring hare* 🌟

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "feat: display list names instead of generic labels while editing robots" directly and clearly summarizes the main change described in the raw_summary. The title is specific, concise, and uses proper semantic versioning convention (feat:) to indicate a feature addition. It accurately reflects that the changeset modifies how limit field labels are displayed by deriving them from actual list/action names rather than using generic placeholder labels.
Linked Issues Check ✅ Passed The pull request successfully addresses the requirement in linked issue #852. The raw_summary confirms that the renderScrapeListLimitFields block now derives limit field labels from the corresponding scrapeList action names (using the action's name, its first arg's __name, or falling back to a generic label), which directly replaces the previous behavior of displaying generic labels like "list 1 limit" with actual list names as required. The implementation aligns with the expected behavior specified in the issue.
Out of Scope Changes Check ✅ Passed The changes appear to be appropriately scoped to the linked issue requirements. Only one file (src/components/robot/pages/RobotEditPage.tsx) was modified, and the changes are focused on updating how the renderScrapeListLimitFields block derives labels from action names. The raw_summary indicates that control flow and rendering logic remain unchanged, suggesting the modification is narrow and targeted to the specific objective of displaying list names instead of generic labels.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-list-limits

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot reviewed Nov 1, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/components/robot/pages/RobotEditPage.tsx (1)

440-446: Good backward compatibility handling for legacy __name field.

The code properly updates both the standard name field and the legacy __name field (if present), ensuring synchronization. The defensive type checking and error handling are appropriate for this scenario.

Minor consideration: If the legacy field update fails, only console logging occurs. This is likely acceptable since the primary name field is still updated, but consider whether users should be notified if this matters for data integrity.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b032de4 and a94b2c5.

📒 Files selected for processing (1)
  • src/components/robot/pages/RobotEditPage.tsx (1 hunks)
🔇 Additional comments (1)
src/components/robot/pages/RobotEditPage.tsx (1)

513-542: LGTM! Well-implemented label derivation with proper fallbacks.

The logic correctly retrieves the action name from the scrapeList action and uses it as the TextField label, with appropriate fallbacks to the legacy __name field and a sensible default. The optional chaining handles edge cases gracefully.

@amhsirak amhsirak merged commit 9cf8537 into develop Nov 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enhancement: Display list names instead of generic labels while editing robots

2 participants

@amhsirak